[ODE] Small memory bug in gimpact

Bram Stolk b.stolk at gmail.com
Tue Nov 20 09:41:36 MST 2007


On Nov 19, 2007 11:37 PM, Daniel K. O. <danielko.listas at gmail.com> wrote:

> Chunky Kibbles escreveu:
>
> > That *fp=0.0f is always assigning a value to the memory pointed to by
> > a a null pointer, which throws an exception here.
>
> That looks more like a poor man's assert(). I would prefer a SIGABRT +
> some descriptive message in stderr ("out of memory") than a SIGSEGV.
>

Indeed.
I changed it to an assert in the SVN trunk.

Note: I opted not to use dIASSERT(), although this one gives a nice abort,
and is used throughout ode, it turned out that nowhere in GIMPACT any
reference is made to ODE includes. I did not wat to polute the GIMPACT src
with ODE includes, so I use assert.h which was already used in GIMPACT, so
it cannot break any builds.

  Bram


-- 
Zapp: Captain's log, stardate...er..
Kif: Ohhh. April 13th.
Zapp: April 13th. Point 2.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://ode.org/pipermail/ode/attachments/20071120/e1aaef90/attachment.htm


More information about the ODE mailing list